Re: [PEPr] +1 for Event::Dispatcher

Justin Patrin wrote: > >Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the >proposal for Event::Dispatcher. > >Proposal information: >http://pear.php.net/pepr/pepr-proposal-show.php?id=186 >Vote information: >http://pear.php.net/pepr/pepr-vote-show.php?id=186&handle=justinpatrin > >This vote is conditional. The condition is: > >I'm glad to finally see a standardized notification system. I'm probably going >to start using it today. :-) I suggest you wait until the package is accepted and released because things have changed a little and the tarball is not up to date. >- Member vars should have docblocks with @access (if not public) and (short) >description of what they are (Notification.php) I don't think it is necessary to document private vars, but this has been done by Stephan anyway. >- the @VER@ entry doesn't seem to be altered in the files when installing the >package. (Hmmm, there's no package.xml. I didn't realize that PEAR would install >without a package.xml. I'm further surprised that it put them in the Event >folder. Even the tests went in the right place. Interesting. ^_^ Nice job, >installer author(s)!) There must be a package.xml in the tarball (?) Bertrand