Re: Re: cvs: pear /Validate/Validate ISPN.php

On Fri, 2005-01-21 at 16:37, Daniel Convissor wrote: > Hi Helgi: > > On Fri, Jan 21, 2005 at 02:52:57AM -0000, Helgi ormar orbjrnsson wrote: > > > function ean8($ean) > ... snip ... > > + return Validate_ISPN::_process($ean, 8, $weights_ean8); > > } > ... snip ... > > + function _process($data, $length, &$weights) > > I see _process() is private. What I'm suggesting is one method that a > user can call to validate any number. Just in case you don't know, > numbers that are shorter than 14 are left padded with 0's. Then I should rather have made _checkControlNumber public or something, or people just extend the class or something if they need something special ;) Anyway I and Pierre aren't to found of taking this approach, so we'll stay with it as is for now. > > > unified ean, ucc and sscc funcs like Daniel C suggested, still some issues with those > > static things left. > > add @access doc block > > ... snip ... > > > + * @access public > > * @param string $isbn number (only numeric chars will be considered) > > * @return bool true if number is valid, otherwise false > > Another pedantic comment... @access should come after @return. > http://pear.php.net/manual/en/standards.sample.php > > Thanks, > > --Dan Nitpicking :-) I didn't even know we had a standard on if the @access should be on some special line, but well I'll fix it then. - Helgi