Re: Re: cvs: pear /Validate/Validate ISPN.php

On Fri, 2005-01-21 at 17:41, Daniel Convissor wrote: > Hey: > > On Fri, Jan 21, 2005 at 05:22:02PM +0000, Helgi ?ormar wrote: > > > > Then I should rather have made _checkControlNumber public or something, > > or people just extend the class or something if they need something > > special ;) > > Once we get to PHP 5's enforced public/private model, one can't do that if > it's private. Well it's still PHP4 so we aren't worried yet :-) > > Anyway I and Pierre aren't to found of taking this approach, so we'll > > stay with it as is for now. > > So much for making the package easy to use in a point of sale program or > something similar. Well I said for now, we're still in alpha and next release will be alpha so we can still do drastic changes if needed, I could make the _process method public, and add the modulo and subtract param and pass that to _checkControlNumber and remove the commented out code and require people to pass their own weight array, that way I'd solve the extend part and the open part, but I'd like to ponder about this a little longer. Anyway I'm glad to see your interest in this ;) - Helgi