Re: [File_CSV] Patch

On Sat, 2005-01-29 at 20:57, Firman Wandayandi wrote: > On Sat, 29 Jan 2005 20:53:36 +0000, Helgi Þormar <helgi@trance.is> wrote: > > On Sat, 2005-01-29 at 20:41, Helgi Þormar wrote: > > > On Sat, 2005-01-29 at 20:28, Firman Wandayandi wrote: > > > > File_CSV Changelog: > > > > =============== > > > > - Fixed bugs: Fields count less nor more than expected handling > > > > - Added Mac EOL support > > > > > > > > Complete Test > > > > =========== > > > > > > > > http://firman.dotgeek.org/downloads/File_CSV-patch.tgz > > > > I'm of course only talking about the Mac EOL support in the text below, > > the other thing can get in just find (and well most of all the \r stuff > > since it won't bother anything, just the ini_set stuff and eol2unix will > > probably have to wait :/) > > > > ini_set for "auto_detect_line_endings" I think this should be > included, coz the Mac EOL in discoverFormat() need this. eol2unix is > EOL compatibily for storage, this can wait anyway. Well it all depends on if we want to push the whole File package to have PHP 4.3.0 dep or not, because CSV can't be used with that change in any version below 4.3.0 =) Afaik the 4.3.0 optional dep on File atm is because file_get_contents is used if the version is 4.3.0+ but I might be wrong, we'll see when Mike answers me ... One thing we could also do is to do some version_compare checks and only have the Mac EOL stuff included if the person is using 4.3.0 or higher ;) I'm at least looking through the whole thing and applying changes to my CSV package and seeing how you did things and what changed, then I'll see what I'll do with File_CSV =) Btw. you accidentally left some print function in the code ;) heh - Helgi