Re: [File_CSV] Patch

On Sat, 2005-01-29 at 20:41, Helgi Þormar wrote: > On Sat, 2005-01-29 at 20:28, Firman Wandayandi wrote: > > File_CSV Changelog: > > =============== > > - Fixed bugs: Fields count less nor more than expected handling > > - Added Mac EOL support > > > > Complete Test > > =========== > > http://firman.dotgeek.org/downloads/File_CSV-patch.tgz I'm of course only talking about the Mac EOL support in the text below, the other thing can get in just find (and well most of all the \r stuff since it won't bother anything, just the ini_set stuff and eol2unix will probably have to wait :/) > Hi, > > Looks nice, but I'm not sure if I want to add this, because of the PHP > 4.3.0 dep you place in there, I rather don't want to introduce that, > even tho we have optional PHP 4.3.0 dep already. > > But I see you're doing similar EOL checks like I did in my CSV package, > which is very good indeed :) > > But like I say, it's kinda hard to decide upon thing like this, I might > be able to do this when PEAR 1.4.0 is out and I split the File_CSV part > into it's own package. > > Mike what do you think we should do ? > Because this gets us kinda cornered, if we accept it as is, then we have > to higher the PHP version for all the File package (IMHO anyway), it's > just the question if we want to limit our self like that ? :-) > > - Helgi