Re: [PEPr] Comment on File Formats::pOOcl
| From: | Vincent Lascaux | Date: | Thu, 03 Feb 2005 01:21:48 +0000 |
| Subject: | Re: [PEPr] Comment on File Formats::pOOcl | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-35897@lists.php.net to get a copy of this message | ||
> What are the chances you could pop up some .phps files so we can see the
> full glory of your work?
OK, I'm working on it...
> You should know right now that pOOcl is unlikely to be accepted as pOOcl,
> but it is likely to be accepted as something like Archive with subclasses
> Archive_Writer/Archive_Reader [note: before a flame war starts, the name
> "Archive" is just a suggestion]. The main reason is that the name pOOcl
> doesn't describe what the thing does.
That sounds OK to me
> I took a quick look at the code, and the size is impressive. You have
> decent docs, also. Before proposing this to PEAR, however, you need to
> spend some attention to a few of the basic coding standards. Most
> important is:
> [snip]
I know that I would have to rework my code so that it can be accepted.
I heard about class naming conventions, file conventions too...
> I really admire the work you've put into this, just a few tweaks and it
> would be PEAR-ready.
Thank you for you compliments ;)
--
Vincent