[PEPr] Comment on HTML::PHORM
| From: | Stefan Ohrmann | Date: | Tue, 08 Feb 2005 10:38:13 +0000 |
| Subject: | [PEPr] Comment on HTML::PHORM | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-36052@lists.php.net to get a copy of this message | ||
Stefan Ohrmann (http://pear.php.net/user/ohrmann) has commented on the proposal for HTML::PHORM.
Comment:
In you give a dependency "PHP <= 5", but in your classes you always use
"__construct", which won't will work with PHP4.
Then you use a custom error handler based on "set_error_handler" which
isn't recommended.
Your naming scheme doesn't use the PEAR naming scheme:
<http://pear.php.net/manual/en/standards.naming.php>
Also it is recommended to use one class per file.
I don't think that your proposal will be accepted, because it's to less
reusable.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=206
--
Sent by PEPr, the automatic proposal system at http://pear.php.net