[PEPr] Comment on HTML::PHORM
| From: | Christian Weiske | Date: | Fri, 22 Jul 2005 17:22:06 +0000 |
| Subject: | [PEPr] Comment on HTML::PHORM | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38842@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for HTML::PHORM.
Comment:
- Class names do not match any package structure
- You echo code directly instead of giving back strings
- You give out <html> tags instead of the needed code only
- Many CS issues
- Split up the classes in several files
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=206
--
Sent by PEPr, the automatic proposal system at http://pear.php.net