[PEPr] Comment on PEAR::PEAR_Delegator
| From: | Stephan Schmidt | Date: | Wed, 23 Feb 2005 12:11:21 +0000 |
| Subject: | [PEPr] Comment on PEAR::PEAR_Delegator | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-36352@lists.php.net to get a copy of this message | ||
Stephan Schmidt (http://pear.php.net/user/schst) has commented on the proposal for
PEAR::PEAR_Delegator.
Comment:
I really like the package and would love to have this in PEAR.
Some short comments:
- Please adjust your code to PEAR coding standards
- Think about using PEAR_Exception instead of the built-in Exception
class. It provides some cool features like pretty-printed output and
observers
- Why don't you declare cacheMethod() as private if it should not be
called from outside the class?
- Why are you extending PEAR? I only found to calls to raiseError() which
actually encapsulate exceptions. I'd prefer if you package this exception
into a new PEAR_Exception and throw this instead of using PEAR_Error
objects.
but apart from that, this package is really great. Thanks for your
contribution.
Stephan
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=210
--
Sent by PEPr, the automatic proposal system at http://pear.php.net