[PEPr] Comment on Web Services::Trackback

Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for Web Services::Trackback. Comment: Thanks for removing the overloading, PHP4 overloading is very broken. In Trackback.php you have a constructor with some docblocks (and params) but no implementation. Looks like those params should be for the create function. The following is, of course, my opinion, but makes sense to me from a style perspective. I would suggest not using a heredoc in getResponseSuccess(). You only use single quotes in there so it would be very simple to just use double quotes instead of the heredoc. I also noticed that you used single quotes for your attributes in the <?xml sections. Why not use double quotes for the attributes and single quotes for the strings? Additionally, you're using double quotes for the strings in getResponseError() when single quotes would be sufficient. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=217 -- Sent by PEPr, the automatic proposal system at http://pear.php.net