Re: Patch for <label> in HTML_QuickForm

Hi, Turadg Aleahmad wrote:

I've begun to use HTML_QuickForm and it's very handy. I'm just using the Default renderer at this point. I noticed the omission of the <label> tag around the {label} string. Specifying <label> lets the browser know that the string is a label and lets it do some extra stuff. For example, recent browsers will focus on the input element when you click on its label.

...

I've tested this in my use and it works as advertised. I don't use QuickForm very extensively so it may break some cases that I don't have in my code. I trust the package maintainers will know if this might break anything.

The patch is definitely not sufficient, as it does not take into account numerous possibilites. One of the obvious questions: what happens if someone is adding labels with <label> tags already appended? The automatic adding of <label> tags is considered for QuickForm 4, but that is still in early planning stages.