Re: [PEPr] Comment on Encryption::GPG

Looks quite good, I especially like that you used pipes to communicate with the GPG binary. I'd suggest back porting it to php4 as well as a majority of the people who will use it will undoubtly probably be stuck on php4 for a variety of reasons. In fact, I'll probably backport it myself tonight as I have an application I just finished that has a single method GPG class that I was planning on expanding on in the near future, but looks like you already done it. ;) Cheers, JC On 24 Mar 2005 02:49:58 -0000, Matthew Fonda <mfonda@php.net> wrote: > > Matthew Fonda (http://pear.php.net/user/mfonda) has commented on the proposal for > Encryption::GPG. > > Comment: > > Looks alright to me. > > Is there any way you could make this package not require PHP5? It doesnt > seem like you necessarily need to use it. Perhaps just use PEAR_Error > instead of exceptions. Also, PEAR and the GPL don't mix. Maybe consider > using the PHP license. > > Also, make sure everything is up to par with the PEAR coding standards. > Private methods should still follow standards, so for example you would > use _openSubprocess() instead of open_subprocess(). And on your if > statements, make sure you use { and } even if it is just a one liner. Your > class should also be named Crypt_GPG. > > Other than that it looks pretty good. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=229 > > -- > Sent by PEPr, the automatic proposal system at > http://pear.php.net > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >