[PEPr] Comment on Encryption::Crypt_RSA
| From: | Matthew Fonda | Date: | Thu, 31 Mar 2005 02:23:08 +0000 |
| Subject: | [PEPr] Comment on Encryption::Crypt_RSA | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37018@lists.php.net to get a copy of this message | ||
Matthew Fonda (http://pear.php.net/user/mfonda) has commented on the proposal for
Encryption::Crypt_RSA.
Comment:
Looks very nice and useful to me. And as Helgi said, it would be nice to
put up a .phps, makes things much easier.
Theres a few minor CS issues:
*All classes should be in their own file, with the name of the class - so
RSAKey.php would contain Crypt_RSAKey class, etc
*Method names should follow "studly caps " scheme, for example use
generateKeyPair instead of generate_key_pair.
Looks nice so far.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=234
--
Sent by PEPr, the automatic proposal system at http://pear.php.net