[PEPr] +1 for Encryption::Crypt_RSA

From: Date: Thu, 14 Apr 2005 04:53:53 +0000
Subject: [PEPr] +1 for Encryption::Crypt_RSA
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-37229@lists.php.net to get a copy of this message
Matthew Fonda (http://pear.php.net/user/mfonda) has voted +1 on the proposal for Encryption::Crypt_RSA. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=234 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=234&handle=mfonda This vote is conditional. The condition is: I am +1 if you fix a few things up first. Most of the concerns I have were already voiced by Phillipe Jausions on the mailing list. I would like to see you do most of the things he wrote in his post (http://news.php.net/php.pear.dev/37214) Mainly, use the class/directory structure Phillipe suggested, it makes everything much cleaner and it's compliant with PEAR standards. Also, use PEAR_Error for error handling as opposed to using exit(). Also, as suggested I would like to see a factory method used for creating the object. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#37229) next »