[PEPr] Comment on PEAR::PEAR_PackageFileManager_GUI_Gtk
| From: | Daniel Convissor | Date: | Mon, 04 Apr 2005 15:31:22 +0000 |
| Subject: | [PEPr] Comment on PEAR::PEAR_PackageFileManager_GUI_Gtk | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37075@lists.php.net to get a copy of this message | ||
Daniel Convissor (http://pear.php.net/user/danielc) has commented on the proposal for
PEAR::PEAR_PackageFileManager_GUI_Gtk.
Comment:
Nice job with adhering to the coding standards. A few things still need to
be cleaned up, please.
* Remove the old file header. Just use the docblock header.
* Fix the order and usage of the @ tags in the header and method
docblocks. See the Coding Standards for more info.
* When noting the use of references, I believe hte right format is putting
the "&" at the variable name not the variable type (eg: @param object
&$entry).
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=226
--
Sent by PEPr, the automatic proposal system at http://pear.php.net