Re: [PEPr] Comment on PEAR::PEAR_PackageFileManager_GUI_Gtk
| From: | Scott Mattocks | Date: | Mon, 04 Apr 2005 18:03:27 +0000 |
| Subject: | Re: [PEPr] Comment on PEAR::PEAR_PackageFileManager_GUI_Gtk | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37076@lists.php.net to get a copy of this message | ||
Daniel Convissor wrote:
Comment: Nice job with adhering to the coding standards. A few things still need to be cleaned up, please. * Remove the old file header. Just use the docblock header. * Fix the order and usage of the @ tags in the header and method docblocks. See the Coding Standards for more info. * When noting the use of references, I believe hte right format is putting the "&" at the variable name not the variable type (eg: @param object &$entry).Thanks, Dan. I will make these changes and have them up tomorrow. I am not going to let this hold up the switch to CfV mode though. After I update the code I will call for votes unless there are any more comments. Thanks, Scott Mattocks