Re: Status of Validate
| From: | Torsten Roehr | Date: | Mon, 04 Apr 2005 17:43:48 +0000 |
| Subject: | Re: Status of Validate | ||
| References: | 1 2 3 4 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37077@lists.php.net to get a copy of this message | ||
"Helgi Þormar" <helgi@trance.is> wrote in message
news:1112611234.5470.69.camel@megatokyo...
> On Mon, 2005-04-04 at 12:36 +0200, Torsten Roehr wrote:
>
> > I've just created a diff for one of the two open requests (incl.
extended
> > unit test):
> > http://pear.php.net/bugs/bug.php?id=997 (URIs to the
> > diffs/files can be
> > found in the comments)
>
> I let Pierre know about it since he's assigned to it.
> Now the ball is on his side regarding that bug report.
>
> - Helgi
Helgi, thanks for applying the patch! I've just opened another feature
request with two patches for Validate::multiple() and
Validate_Financial_CreditCard::number() as well as a unit test for
Validate::multiple().
As far as I have seen, unit tests are only missing for string() and uri().
As string() and uri() are not very complex it would practically mean testing
PHP's preg_match() - I don't think this makes sense.
So it looks quite good quality wise. Hope this gets things rolling a bit ;)
I'm looking forward to the next release.
Thanks and best regards,
Torsten