[PEPr] Comment on Networking::Net_SMPP_Client
| From: | Mirco Bauer | Date: | Sat, 23 Apr 2005 13:40:18 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_SMPP_Client | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37369@lists.php.net to get a copy of this message | ||
Mirco Bauer (http://pear.php.net/user/meebey) has commented on the proposal for
Networking::Net_SMPP_Client.
Comment:
Do not use globals, use a variable inside your class instead. (relying on
globals btw shows bad OO design)
the class itself looks ok, but you pass references to bools?!? having
return values which are references is ok, but that is mainly for objects.
please correct this two issues.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=240
--
Sent by PEPr, the automatic proposal system at http://pear.php.net