[PEPr] Comment on File Formats::Archive_Ar

From: Date: Sun, 01 May 2005 17:45:45 +0000
Subject: [PEPr] Comment on File Formats::Archive_Ar
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-37467@lists.php.net to get a copy of this message
Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for File Formats::Archive_Ar. Comment: This format is also used for the ipkg format (which is basically the same as a Debian Archive) which is used for OpenZaurus, Familiar, and OpenSimpad. I don't think that printFiles method should really be in there. If a user want to print a table listing of the files it's just as easy to use Structures_DataGrid and the file array. The keys of the file array are a bit strange. 'sz' for size seems a bit simple. Why not just ise 'size'? Also, 'modt' instead of 'mtime'...why not just use the standard 'mtime'? Having a local _isError function is useless as you're already requiring PEAR.php. Just use PEAR::isError(). I would personally rather you used ' instead of " for all strings that don't need ". i.e. all strings without \n or variables in them. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=243 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#37467) next »