Re: [PEPr] +1 for Math::Math_Finance

Thanks Helgi and Matt, I appreciate your comments. I understand your concerns about the coding standards. The function names are like that because the principal goal of this package is to provide the same interface as Excel's financial functions, which are all uppercase abbreviations. Moreover, the financial litterature does the same. So I think we can make an exception here without hurting too much PEAR's standards. I'll put the braces around the one-liners ifs. Regarding the singleton, why is it that you don't like it? It's the same technique used in the LiveUser main script. Best Regards, Alejandro Helgi Þormar <helgi@trance.is> escribió: >Helgi Þormar (http://pear.php.net/user/dufuz) has voted +1 on the proposal >for Math::Math_Finance. > >Proposal information: >http://pear.php.net/pepr/pepr-proposal-show.php?id=225 >Vote information: >http://pear.php.net/pepr/pepr-vote-show.php?id=225&handle=dufuz > >This vote is conditional. The condition is: > >What Matt said really, Coding Standard fixes, for example, do not skip {} >when you do a if sentence. > >also the singleton method (getInstance) isn't a real singleton method IMHO, >you should rework it, packages like LiveUser and iirc Log have good >implementations for example. > >-- >Sent by PEPr, the automatic proposal system at >http://pear.php.net > >-- >PEAR Development Mailing List (http://pear.php.net/) >To unsubscribe, visit: http://www.php.net/unsub.php >