Re: [Patch] only a notice correction
| From: | Arnaud Limbourg | Date: | Sun, 05 Jun 2005 09:07:26 +0000 |
| Subject: | Re: [Patch] only a notice correction | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37970@lists.php.net to get a copy of this message | ||
Hi,
The best is to open a bug so that the patch does not get forgotten.
Please mention the circumstances under which the notice happen as I had
a look and line 868 is a }
Arnaud.
Diana Soares wrote:
> I only defined $name in setName() when using $mode='seq' because it
> printed a notice message of undefined variable $name at line 868.
>
> I'm using the revision 1.49 of file Upload.php checked out from cvs
> today.
>
> switch()
> ....
> case 'seq':
> $name = '';
> ...
>
> Good work,
>
>
>
> ------------------------------------------------------------------------
>
> ? HTTP_Upload.diff
> ? Request
> ? Request.php
> Index: Upload.php
> ===================================================================
> RCS file: /repository/pear/HTTP_Upload/Upload.php,v
> retrieving revision 1.49
> diff -u -r1.49 Upload.php
> --- Upload.php 12 Dec 2004 19:39:43 -0000 1.49
> +++ Upload.php 1 Jun 2005 15:57:24 -0000
> @@ -676,6 +676,7 @@
> $name = $this->upload['real'];
> break;
> case 'seq':
> + $name = '';
> $this->_modeNameSeq['flag'] = true;
> $this->_modeNameSeq['prepend'] = $prepend;
> $this->_modeNameSeq['append'] = $append;
>
>