Re: [PEPr] Call for votes on Web Services::Services_Webservice

Manfred Weber wrote:

Manfred Weber (http://pear.php.net/user/crafics) has initiated the call for votes on Web Services::Services_Webservice. Please review the proposal and give your vote here: http://pear.php.net/pepr/pepr-proposal-show.php?id=262

Ok, I probably should have commented earlier, but here we go: 1. As Sergio requested, it would have been better to have direct access to the source (.phps) instead of the .tgz... which I have now downloaded and found out there's only 1 class file in it, so it wouldn't have been too hard to simply add .phps link... 2. A lot of CS problem, especially in the lack of spaces around operators and so on. 3. Extending the Webservices_Webservice class is not good and too restrictive. You should should use a decorator pattern that would accept a class name or an instance of it on which you run the reflection functions, and use the __call() PHP5 feature to pass the queries. 4. There is certainly a way to get some work with the upcoming XML_RPC2. Maybe the XML_RPC2_Server should be spun into some kind of XMLRPC profile to a generic WebService_Server package. We don't want to duplicate efforts to implement reflection, docblock parsing and so on for each different webservice protocol. As is, I would probably vote a -1. But will hold my vote for now, to see how things are going first. -Philippe