[PEPr] Comment on Web Services::Services_Upcoming

Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for Web Services::Services_Upcoming. Comment: You .tgz is apparently a .tar.gz.gz... Best to provide direct links to the .phps especially since you only have a couple of files in it. Header docblock missing, See http://pear.php.net/manual/en/standards.header.php End of Lines should be UNIX not Windows... "} elseif (... " in one line, not "elseif" below the "}" Private members should start with "_" You probably forgot the return by reference "&" for getCache() method... Do "@return array|PEAR_Error Result of call or PEAR_Error on failure" instead of multiple @return docblock statements. The mapping of "." to "_" for method names is interesting, although it breaks the PEAR CS. I'm not sure how this should be handled throughout PEAR, you may want to make a call on that. Always put {} for if statements. For instance around line 226. Put spaces around operators, for instance around line 258 (default value for parameters) watchlist_getList() doesn't have default values while the docblock suggest otherwise. watchlist_remove() calls the "watchlist.add" services... Probably not good. trigger_error() around line 1050 and similar other places. you probably want to return the PEAR_Error instead. -Philippe Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=244 -- Sent by PEPr, the automatic proposal system at http://pear.php.net