Re: is it time to remove tokenizing of role="php"?

On Thursday 28 July 2005 11:33 am, Greg Beaver wrote: > Hi all, > > With the advent of .phar files, as well as bcompiler files, I wonder if > it is time to re-evaluate the decision to parse all files with > role="php" for validating the code. This action causes all kinds of > interesting beeps and weird characters on the screen when validating any > binary files, as token_get_all() does not do well with non-ASCII > characters. > > I would like to remove the analysis of role="php" from package.xml > validation altogether. This will also have a side benefit of > significantly speeding up packaging, and it will reduce the memory > footprint of PEAR due to deleted code. > > Any differing or supporting opinions? > I concur with Joe. A pre-final-packaging lint check is an easy way to make sure a package doesn't get released with parse errors. I'd suggest either: - Adding a non-"php" role for phar files - Changing the lint code to only check files which are role="php" /and/ end in ".php"

Attachment: [application/pgp-signature]