Re: is it time to remove tokenizing of role="php"?

Well, regardless, I think that stuff like that is good. It sounds like it's barfing on binary files, so we should merely create a binary file role that gets ignored during the process - not remove sanity, lint and parse checking from PHP files. This is the whole point of role="foo" I would think. --Joe On Jul 28, 2005, at 1:20 PM, Justin Patrin wrote:

On 7/28/05, Ian Eure <ieure@php.net> wrote:

On Thursday 28 July 2005 11:33 am, Greg Beaver wrote:

Hi all, With the advent of .phar files, as well as bcompiler files, I wonder if it is time to re-evaluate the decision to parse all files with role="php" for validating the code. This action causes all kinds of interesting beeps and weird characters on the screen when validating any binary files, as token_get_all() does not do well with non-ASCII characters. I would like to remove the analysis of role="php" from package.xml validation altogether. This will also have a side benefit of significantly speeding up packaging, and it will reduce the memory footprint of PEAR due to deleted code. Any differing or supporting opinions?

I concur with Joe. A pre-final-packaging lint check is an easy way to make sure a package doesn't get released with parse errors. I'd suggest either: - Adding a non-"php" role for phar files - Changing the lint code to only check files which are role="php" /and/ end in ".php"

It's not just a lint check. It's actually parsing the files (note Greg mentioned token_get_all()) and checking for PHP version compatibility and such. There may be more but I haven't actually checked the code myself. --Justin Patrin -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php