[PATCH] Fixes error handling in Net_IDNA_php5
| From: | Benjamin Muskalla | Date: | Thu, 11 Aug 2005 01:35:56 +0000 |
| Subject: | [PATCH] Fixes error handling in Net_IDNA_php5 | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-39306@lists.php.net to get a copy of this message | ||
I do not understand why some errors should raise an exception and others
(with same priority) only set an error message. I think when someone
uses php5, he will do the error handling with exceptions.
The PHP5 class still uses $this->_error to report errors to the user.
Here is a little patch that throws an exception on every encode/decode
failing.
I hope someone will update the package with this patch.
More patches for Net_IDNA will follow these days.
Thanks!
Benny
Attachment: [text/x-patch] exception.patch
Attachment: [text/x-patch] exception.patch