Re: Re: cvs: pear /DB_Table package.xml /DB_Table/DB Table.php /DB_Table/DB/Table QuickForm.php
| From: | Alan Knowles | Date: | Thu, 18 Aug 2005 08:19:58 +0000 |
| Subject: | Re: Re: cvs: pear /DB_Table package.xml /DB_Table/DB Table.php /DB_Table/DB/Table QuickForm.php | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-39456@lists.php.net to get a copy of this message | ||
On Thu, 2005-08-18 at 09:40 +0200, Lukas Kahwe Smith wrote:
> Alan Knowles wrote:
>
> > For the switch case you should put an extra line after the break;
> > + break;
> > + default: // use addRule() for all other elements
> >
> > (personally I indent the cases once more, but I suspect the package
> > doesnt do that, so you are probably right to follow the existing code.)
>
> as per CS additional indenting is a no no :-)
> http://pear.php.net/manual/en/standards.control.php
I think we discussed this before, It is acceptable to put extra
indentation (if the maintainer has done it before), but just not
documented in the manual..
It's hardly a huge thing.. ;)
Regards
Alan
>
> regards,
> Lukas
>