Re: cvs: pear /DB_DataObject DataObject.php
| From: | Torsten Roehr | Date: | Sun, 18 Sep 2005 08:10:39 +0000 |
| Subject: | Re: cvs: pear /DB_DataObject DataObject.php | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-39865@lists.php.net to get a copy of this message | ||
>> @@ -3041,7 +3041,7 @@
>> $fullJoinAs = '';
>> $addJoinAs = ($quoteIdentifiers ?
$DB->quoteIdentifier($obj->__table) : $obj->__table) != $joinAs;
>> if ($addJoinAs) {
>> - $fullJoinAs = "AS {$joinAs}";
>> + $fullJoinAs =
in_array($DB->dsn["phptype"],array('mysql','mysql','pgsql'))
? "AS
{$joinAs}" : $joinAs;
>
>Looks like you have an extra 'mysql' in there.
I guess the second should be "mysqli".
>Also, I'm pretty sure
>you don't need the AS for mysql. I like it better myself as it makes
>the "rename" more apparent, but it's not required.
That's what I pointed out in my bug report, too:
http://pear.php.net/bugs/bug.php?id=5416
(see second paragraph in first comment)
But it's not really a problem.
Best regards, Torsten Roehr