Re: Re: [ANNOUNCEMENT] System_SharedMemory-0.0.4 (beta) Released.

Bonjour, Stefano F. Rausch wrote:

If you don't mind my 2 cents too - after a cursory review: you don't comply with the PCS [1], i.e. don't use tabs to indent, instead use 4 spaces [2], change the EOL to LF and add a trailing LF after the closing PHP tag [3], adhere to the header comment block standard [4] ... see e.g. System/SharedMemory.php Sorry to say, but I'm not happy that this code has been released without further clean up!

You did not comment during the proposal phase , not sure you may be "unhappy" now. I think Evgeny made really great efforts to improve his package. Those CS problems are minor beginner's (in PEAR) faults. I'm confident that will be quick cleaned. I'm more concentrated on the usability/added value ... and here, that package should have get much more as +5 votes ! à+ -- bertrand "toggg" Gugger > > -- Stefano > > [1] http://pear.php.net/manual/en/standards.php > [2] http://pear.php.net/manual/en/standards.php#standards.indenting > [3] http://pear.php.net/manual/en/standards.file.php > [4] http://pear.php.net/manual/en/standards.header.php > > On Sat, 17 Sep 2005 15:58:43 +0200, Lukas Smith <lsmith@php.net> wrote: > >> PEAR Announce wrote: >> >>> The new PEAR package System_SharedMemory-0.0.4 (beta) has been >>> released at http://pear.php.net/. >> >> >> please also have a look at the version naming standard. >> this release is not according to those standards, though its not a big >> deal this early in the game. however make sure you know the standard in >> he future: >> http://pear.php.net/pepr/pepr-proposal-show.php?id=65 >> >> regards, >> Lukas >> >