Re: [PEPr] Proposal for HTML::SimpleCalendar
| From: | Christian Weiske | Date: | Wed, 23 Nov 2005 07:51:30 +0000 |
| Subject: | Re: [PEPr] Proposal for HTML::SimpleCalendar | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40482@lists.php.net to get a copy of this message | ||
Hello Josh,
> Josh Peters (http://pear.php.net/user/enricopulatzo) proposes HTML::SimpleCalendar.
The calendar itself looks good and I can think of many situations where
it can come handy. There are some notes, though:
- When clicking the week view and day view with javascript turned off,
nothing happens - the month isn't changed. However, it works with the
full view.
- Maybe it's Opera only, but the chooser field is clashed together and
empty, although the actual code is in there. Perhaps moving the <form>
tag outside the <fieldset> helps? Don't know
- Is it possible to choose the day in the small choosers without javascript?
- Clean up and document the code!
- Use a template engine to generate HTML, or at least pack the HTML
another file - mixing of code and html is just ugly.
- Separate the javascript and the css.
- Detach the javascript and css, referencing them in the html only, but
don't include the code in every page (external css file and external js
file)
- Try to wrap lines around 70-80 chars, especially the license at the
beginning of the file
- Set the name of your <organization>
--
Regards/MfG,
Christian Weiske
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc