[PEPr] Comment on Text::LanguageDetect
| From: | bertrand Gugger | Date: | Wed, 07 Dec 2005 19:56:26 +0000 |
| Subject: | [PEPr] Comment on Text::LanguageDetect | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40633@lists.php.net to get a copy of this message | ||
bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for
Text::LanguageDetect.
Comment:
Bravo, it's very nice done !
Just 2 points:
* perhaps is done and I missed it, sorry if it's the case, but shouldn't
you compress all multiple spaces (original or derived from non alpha) in a
single space ?
* the datafile should not be in the php directory, you should use the
task/replace from the installer to have it in the data dir. (see
Validate_BE and its package.xml for example and doc in
http://pear.php.net/manual/en/guide.developers.package2.tasks.php#guide.developers.package2.tasks.replace
)
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=331
--
Sent by PEPr, the automatic proposal system at http://pear.php.net