[PEPr] Comment on Text::LanguageDetect
| From: | Stefano F. Rausch | Date: | Tue, 13 Dec 2005 20:29:19 +0000 |
| Subject: | [PEPr] Comment on Text::LanguageDetect | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40721@lists.php.net to get a copy of this message | ||
Stefano F. Rausch (http://pear.php.net/user/sfrausch) has commented on the proposal for
Text::LanguageDetect.
Comment:
Do just a few more PCS correction and you're almost on track:
- some docs comment, e.g. method _sort_func($a, $b), are missing the
@return tag
- try to break the lines at approx. 80-85 chars, e.g. method
_next_char(&$str, &$counter, $special_convert = false)
- convert all tabs to 4 spaces for the indentation
- examples/unit test: require_once is not a function, but a language
construct. Do remove the paranthesis.
Even if it does annoy you, please adhere to the PCS.
I'm looking forward to voting!
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=331
--
Sent by PEPr, the automatic proposal system at http://pear.php.net