[PEPr] Comment on Math::Math_Derivative

From: Date: Mon, 09 Jan 2006 13:40:38 +0000
Subject: [PEPr] Comment on Math::Math_Derivative
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-40910@lists.php.net to get a copy of this message
Jesus M. Castagnetto (http://pear.php.net/user/jmcastagnetto) has commented on the proposal for Math::Math_Derivative. Comment: The code looks good to me on a cursory view. Some minor things, mostly naming of vars and such, for example, there is no "deepness" in english, it should be "depth" (in the parse() method). Also, perhaps the method definedx() could be names defineArgumentVar() or setVariableName() or some such thing, initially I thought the method was checking if "x" was defined because of the name. The bits in the class that should be immutable will be better marked as final, if you want to be only PHP 5 compatible. For what I see, I did not find a reason why this is only PHP 5 compatible, the logic used could be easily done to be BC with PHP 4. Overall, I like the proposal a lot. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=337 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#40910) next »