Re: [PEPr] Comment on Math::Math_Derivative

Hi, thanks for your comments. I changed the things pointed out by Jesus: -Math_Derivative::definedx() +Math_Derivative::setVariableName() -$deepness +$depth I will also make it BC with PHP4 in a near future. Regards Jesus M. Castagnetto wrote: >Jesus M. Castagnetto (http://pear.php.net/user/jmcastagnetto) has commented on the proposal for >Math::Math_Derivative. > >Comment: > >The code looks good to me on a cursory view. > > > >Some minor things, mostly naming of vars and such, for example, there is >no "deepness" in english, it should be "depth" (in the parse() method). >Also, perhaps the method definedx() could be names defineArgumentVar() or >setVariableName() or some such thing, initially I thought the method was >checking if "x" was defined because of the name. > > > >The bits in the class that should be immutable will be better marked as >final, if you want to be only PHP 5 compatible. For what I see, I did not >find a reason why this is only PHP 5 compatible, the logic used could be >easily done to be BC with PHP 4. > > > >Overall, I like the proposal a lot. > >Proposal information: >http://pear.php.net/pepr/pepr-proposal-show.php?id=337 > > > -- Etienne Kneuss http://www.colder.ch/ colder@php.net