R: [PEAR-DEV] [PEPr] +1 for HTML::HTML_QuickForm_Livesearch

> -----Messaggio originale----- > Da: Justin Patrin [mailto:papercrane@reversefold.com] > Inviato: sabato 11 febbraio 2006 23.46 > A: PEAR developer mailinglist > Cc: Justin Patrin; Giuseppe Dessi > Oggetto: [PEAR-DEV] [PEPr] +1 for HTML::HTML_QuickForm_Livesearch > > > Justin Patrin (http://pear.php.net/user/justinpatrin) has > voted +1 on the proposal for HTML::HTML_QuickForm_Livesearch. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=308 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=308&handle=justinpatrin > > This vote is conditional. The condition is: > > All conditionals need curly braces (such as in toHtml in > HTML_QuickForm_LiveSearch_Select). Yes, I'll Fix it. > Output of HTML attributes needs to be escaped correctly > (htmlentities with ENT_QUOTES). This is important for the > output of values in options. > > Please use single quotes in output with concatenation. (in > setting $liveform you use double quotes and interpolation as > well as concatenation. using only single quotes will be (very > slightly) faster and easier to read). Ok, my big bad!! I'll fix it as soon as possible. > I noticed some funky indenting in a few places, please make > sure that everything is indented correctly and not using tabs. Sure! some coding standard issues are still in place due to revert form non standard code to pear standard. > livesearch.class.php does not fit the PEAR naming scheme. I > saw this in the AJAX server class, but didn't see an actual file. It's only an example, the livesearch.class.php is a user php file which contain the search functions. Il''fix it to make the example more standard . > I would very much prefer the use of quotes over HEREDOC, > especially in any cases where you're adding PHP variables to > the strings. > Ok, perfect. Thank you for advices. I'll work on it as soon as possible. Regards G.D.