[PEPr] +1 for HTML::HTML_QuickForm_Livesearch

From: Date: Sat, 11 Feb 2006 22:45:39 +0000
Subject: [PEPr] +1 for HTML::HTML_QuickForm_Livesearch
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-41303@lists.php.net to get a copy of this message
Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for HTML::HTML_QuickForm_Livesearch. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=308 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=308&handle=justinpatrin This vote is conditional. The condition is: All conditionals need curly braces (such as in toHtml in HTML_QuickForm_LiveSearch_Select). Output of HTML attributes needs to be escaped correctly (htmlentities with ENT_QUOTES). This is important for the output of values in options. Please use single quotes in output with concatenation. (in setting $liveform you use double quotes and interpolation as well as concatenation. using only single quotes will be (very slightly) faster and easier to read). I noticed some funky indenting in a few places, please make sure that everything is indented correctly and not using tabs. livesearch.class.php does not fit the PEAR naming scheme. I saw this in the AJAX server class, but didn't see an actual file. I would very much prefer the use of quotes over HEREDOC, especially in any cases where you're adding PHP variables to the strings. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#41303) next »