Re: Re: cvs: pear /Benchmark Profiler.php Timer.php

Lukas Kahwe Smith wrote:

Matthias Englert wrote: );

+    function _getOutput($format) {
+        if ($format == 'auto') {
+            if (function_exists('version_compare') &&
+                version_compare(phpversion(), '4.1', 'ge')) {
+                $format = isset($_SERVER['SERVER_PROTOCOL']) ? 'html' : 'plain';
+            } else {
+                global $HTTP_SERVER_VARS;
+                $format = isset($HTTP_SERVER_VARS['SERVER_PROTOCOL']) ? 'html' : 'plain';
+            }
         }

i wonder if it makes sense to maintain this BC code, considering that PEAR itself requires php 4.2

still not 4.3 ? Benchmark is an "old" package, we just proceed to do more. Anyway, we're just some "help" package, not really in production, in that sense, it's certainly not up to us to push up needed release but more adapt us so to be the tiniest possible. If we benchmark something, we just should not be seen, at any rate not consume observed resources. But that's off topic, you just took us as an example.

also it would be nice to have a dep on PEAR and a php version in the package.xml (this one goes to 80% of all package maintainers).

pear: some packages do *not* depend on pear depend on 'PEAR.php' or on the installer ? php: yes we depend on some version of php, any cases +1 from me (just not sure how it can be checked, php side) Regards -- toggg