Re: cvs: pear /Benchmark Profiler.php Timer.php
| From: | Lukas Kahwe Smith | Date: | Wed, 01 Mar 2006 13:46:12 +0000 |
| Subject: | Re: cvs: pear /Benchmark Profiler.php Timer.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41554@lists.php.net to get a copy of this message | ||
Matthias Englert wrote:
);
+ function _getOutput($format) {
+ if ($format == 'auto') {
+ if (function_exists('version_compare') &&
+ version_compare(phpversion(), '4.1', 'ge')) {
+ $format = isset($_SERVER['SERVER_PROTOCOL']) ? 'html' : 'plain';
+ } else {
+ global $HTTP_SERVER_VARS;
+ $format = isset($HTTP_SERVER_VARS['SERVER_PROTOCOL']) ? 'html' : 'plain';
+ }
}
i wonder if it makes sense to maintain this BC code, considering that PEAR itself requires php 4.2
also it would be nice to have a dep on PEAR and a php version in the package.xml (this one goes to 80% of all package maintainers).
regards,
Lukas