Re: [PEPr] Comment on Gtk2 Components::Gtk2_IndexedComboBox

Scott, > - There is no way to set a value by key. You have get_active_key but not > set_active_key. > - I think you should create method aliases that are more inline with PEAR > naming conventions. It will help make the package eaiser to use for people > who are used to working with PEAR packages. Done. > - You don't do any type checking. I don't think PHP-GTK 2 will react > nicely if I try to set a key to an object. It would be nice if you caught > that problem and returned a PEAR_Error before PHP-GTK catches it an spits > out a nasty error message or crashes. The only "nasty" error messages are the "object to string conversion" notices: -------------- PHP Notice: Object of class GtkLabel to string conversion in /data/php-gtk/packs/Gtk2_IndexedComboBox/Gtk2/IndexedComboBox.php on line 50 -------------- So it doesn't crash. -- Regards/MfG, Christian Weiske

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc