Re: Re: PEAR_Delegator

On Sun, 12 Mar 2006 12:43:07 +0100, Martin Jansen wrote: > On Sun Mar 12, 2006 at 09:1014AM +0000, Helgi Þormar wrote: >> On Sun, 12 Mar 2006 02:11:22 -0500, herrwitten wrote: >> >> > I wanted to know if you think it's time to update the status to beta? >> > >> > Any further suggestions? Comments? Criticisms? All welcome. >> >> And it seems to me that you have a very fuckt up Class to Dir mapping >> thing going on there > > Helgi, your tone is slightly inappropriate. Besides that I don't think > we should enforce the "one class per file" by hook or by crook. Michael > aggregated all exception classes into one file, which seems sane. It's not inappropriate unless you're only used to royal British English, and I was not talking about one class per file but rather the fact that he names the files DelegatorExeptions.php when the file is under the folder Delegator thus it really should be Exceptions.php I don't mind having more than one class per file. > What I do suggest is that the files from source/ are moved to ../. > >> Since I've never tried out the package then I can't comment on if it's >> stable or beta worthy ... You might consider adding some examples on >> top of my tests idea to get things a bit more going for others to have >> a glimps into the package :) > > I gave the code a test run some months ago and I believe it works fine. > There don't seem to be any compelling reasons against rolling a beta > release. Having unit tests with PHPUnit2 would be nice though. Mm yeah, tho at least one example would be optimal. - Helgi