Re: PEAR_Delegator
| From: | herrwitten@php.net | Date: | Sun, 19 Mar 2006 00:01:52 +0000 |
| Subject: | Re: PEAR_Delegator | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41864@lists.php.net to get a copy of this message | ||
Here is the file structure proposal:
***Installation***
PEAR/
Delegator.php
Delegator/
Exception/
Exception.php
DelegateUndefined.php
MethodUndefined.php
Internal/
Extension.php
ForwardProxy.php
***Source***
PEAR_Delegator/
Delegator.php
Delegator/
Exception/
Exception.php
DelegateUndefined.php
MethodUndefined.php
Internal/
Extension.php
ForwardProxy.php
Test/
***Files and Classes***
Delegator.php
PEAR_Delegator
Exception.php
PEAR_Delegator_Exception
DelegateUndefined.php
PEAR_Delegator_Exception_DelegateUndefined
MethodUndefined.php
PEAR_Delegator_Exception_MethodUndefined
Extension.php
PEAR_Delegator_Internal_Extension
ForwardingProxy.php
PEAR_Delegator_Internal_ForwardingProxy
Note that this makes the following class name changes:
(However, this should not break much)
PEAR_Delegator_Extensions
=>PEAR_Delegator_Internal_Extension
PEAR_DelegatorInternalForwardingProxy
=> PEAR_Delegator_Internal_ForwardProxy
PEAR_Delegator_ExceptionDelegateUndefined
=> PEAR_Delegator_Exception_DelegateUndefined
PEAR_Delegator_ExceptionMethodUndefined
=>PEAR_Delegator_Exception_MethodUndefined
On 12 Mar 2006, at 6:43 AM, Martin Jansen wrote:
Having unit tests with PHPUnit2 would be nice though.On 12 Mar 2006, at 8:53 AM, Lukas Smith wrote:
I think we should stick to a "one class per file" for "public classes". Abstract classes may be aggregated into a single file.On 12 Mar 2006, at 8:55 AM, Helgi Þormar wrote:
the files DelegatorExeptions.php when the file is under the folder Delegator thus it really should be Exceptions.phpOn 12 Mar 2006, at 6:29 PM, Alan Knowles wrote:
PEAR_Delegator_Exception_* should be in a file PEAR/Delegator/Exception.php (You should probably lazy load this when needed..) PEAR_Delegator_Internal_ForwardProxy should be in a file PEAR/Delegator/Internal/ForwardProxy.php (I assume the intention was to have multiple internal's ?) otherwise that class looks a bit light? (You should probably lazy load this when needed..) PEAR_Delegator_Extensions should be in a file PEAR/Delegator/Extensions.php would this class not be better as PEAR_Delegator_ExtensionBase ? A little discussion in the header area of PEAR_Delegator on the pro/cons (especially on potential code readability) on using delegators would be nice ;)