[PEPr] Comment on Gtk2 Components::Gtk2_QuickForm

Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for Gtk2 Components::Gtk2_QuickForm. Comment: This could be useful for FormBuilder. ;-) Use PEAR_Exception. User is_callable instead of is_null to check callbacks. If you feel you need isIncludable (this is debatable as when an include doesn't happen the developer should see it and deal with it anyway) then use file_exists before is_readable and don't silence the call. (Note that this can fail with safe_mode, if you care. See LiveUser or MDB2's bugs for more.) I don't really have the time to look at any more tonight (there's lots of code here). It does look like you've started a generic form package, though. I would suggest that you make this a QuickForm base package and a GTK2 renderer package. This was we can have different frontends. :-) You may also want to cooperate with the HTML_QuickForm people or at least check out some of the discussions that have happend about the next version of it so that you can implement some of the ideas that were brought up. There is also a wiki with some thoughts about the next version of QuickForm somewhere. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=371 -- Sent by PEPr, the automatic proposal system at http://pear.php.net