Re: [PEPr] Comment on Gtk2 Components::Gtk2_QuickForm

On 3/17/06, Scott Mattocks <scott@crisscott.com> wrote: > Note: I haven't uploaded any changes yet because I have some questions > still. > > Justin Patrin wrote: > > > > Use PEAR_Exception. > > Done. > > > > > User is_callable instead of is_null to check callbacks. > > Done. > > > > > If you feel you need isIncludable (this is debatable as when an include > > doesn't happen the developer should see it and deal with it anyway) then > > use file_exists before is_readable and don't silence the call. (Note that > > this can fail with safe_mode, if you care. See LiveUser or MDB2's bugs for > > more.) > > isIncludable is needed to catch errors before they become a problem. If > the file can't be included I don't want developers to be able to add an > element of that type. The fact that the file isn't there isn't such a > big deal. I just want to prevent bad things from happening later. I > updated the method to use file_exists first. > > > > > I don't really have the time to look at any more tonight (there's lots of > > code here). It does look like you've started a generic form package, > > though. I would suggest that you make this a QuickForm base package and a > > GTK2 renderer package. This was we can have different frontends. :-) > > What category would you suggest the form package be under? The closest > fit I can see is Structures but I am not sure if that really works. If > that is the best fit, I will delete the current proposal and create two > new ones: Structures_Form and Structures_Form_Gtk2. The Gtk2 package > will contain the Gtk2 elements and renderer. The rest (the base class, > interfaces and rules) will be left in the Structures_Form package. > Structures would make sense to me seeing as that's where a similar package is now (Structures_DataGrid). > > > > You may also want to cooperate with the HTML_QuickForm people or at least > > check out some of the discussions that have happend about the next version > > of it so that you can implement some of the ideas that were brought up. > > There is also a wiki with some thoughts about the next version of > > QuickForm somewhere. > > Can someone please tell me how to join in on this discussion or at least > what mailing list to lurk in? > I suggest checking the pear-dev and pear-general mailing list archives. Unfortunately I'm not sure of the specific threads and such this all may have been under. There were a few wiki pages up, but they seem to have been taken down for some reason. You can still see them in the Google Cache. http://www.google.com/search?hl=en&lr=&q=QuickForm4Wiki&btnG=Search -- Justin Patrin