[PEPr] +1 for Networking::Net_CDDB
| From: | Christian Weiske | Date: | Mon, 10 Apr 2006 21:04:06 +0000 |
| Subject: | [PEPr] +1 for Networking::Net_CDDB | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-42188@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for
Networking::Net_CDDB.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=320
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=320&handle=cweiske
Comment:
Useful package, just a few notes:
- You are using constants like NET_CDDB_VERSION in the protocol
implementations, although the constants aren't defined there and you don't
include the necessary file there.
- Net_CDDB_cddiscid#calcTrackOffsets: the if construct needs brackets
according to CS.
- It seems to me as if the discid class works on *nix only because you use
sudo. A OS specific switch would be nice
- function Net_CDDB($protocol: documented parameterr is $backend
--
Sent by PEPr, the automatic proposal system at http://pear.php.net