Re: [PEPr] +1 for Networking::Net_CDDB

Thanks Christian, I'll fix those few things you talked about. I have a working Win32 version in development, just a few things to tweak. I had a lot of problems finding a stable and working command-line executable to read the CD TOC in Win32. Next version will have Windows support though. - Keith Christian Weiske wrote:

Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for Networking::Net_CDDB. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=320 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=320&handle=cweiske Comment: Useful package, just a few notes: - You are using constants like NET_CDDB_VERSION in the protocol implementations, although the constants aren't defined there and you don't include the necessary file there. - Net_CDDB_cddiscid#calcTrackOffsets: the if construct needs brackets according to CS. - It seems to me as if the discid class works on *nix only because you use sudo. A OS specific switch would be nice - function Net_CDDB($protocol: documented parameterr is $backend