Re: PEAR_Exception changes

On Fri, 23 Jun 2006 10:25:23 -0400 hans@velum.net (Hans Lellelid) wrote: > Hi, > > I'd like to propose some changes to PEAR_Exception. Thomas, Bertrand, Thomas? > and I worked on the original version some time ago, and after a bit of > actual use, I have some proposals for improving the way that it > handles wrapped exceptions. In particular, I like to see all the > stack traces for the exceptions that were re-thrown -- and I imagine > that others would like this feature also. > > So, my questions: > > 1) Where is the best place to send the patches (I don't think I have > commit access to that file directly, and even if I do, I imagine > changes to core functionality need to be audited.) Can you open an issue in our bug tracker and post a link to the patch? Also discussions should stand in the pear.core list. > 2) What is the policy for making public/protected API changes to > PEAR_Exception? E.g. my proposal would change one of the methods to > make it static. Does any stable package make intimate use (i.e. > extend, call non-stock Exception methods) of PEAR_Exception? (I use > it in Net_GeoIP, but only to throw -- and also that packge is not > marked stable, since I didn't think PEAR_Exception was considered > "stable"). As far as I remember this class is still experimental, it is not a problem to change the API. > Also, must PEAR_Exception be compatible with PHP 5.0.x (as opposed to > 5.1.x)? (I assume yes, but figured I'd ask.) I would hate to introduce php 5.0.x as a minimum PHP version. PHP 5.0 was an alpha version of what we have in 5.1. That's also one of the reason I do not like to run too fast in the "let define strict rules for 5.x now". Cheers, -- Pierre