Re: Re: PEAR_Exception changes

On 6/26/06, Hans Lellelid <hans@velum.net> wrote:

Hi, Thanks for the response - Pierre wrote: On Fri, 23 Jun 2006 10:25:23 -0400 hans@velum.net (Hans Lellelid) wrote:

Hi, I'd like to propose some changes to PEAR_Exception. Thomas, Bertrand,

Thomas? Yeah - http://pear.php.net/user/cox

and I worked on the original version some time ago, and after a bit of actual use, I have some proposals for improving the way that it handles wrapped exceptions. In particular, I like to see all the stack traces for the exceptions that were re-thrown -- and I imagine that others would like this feature also. So, my questions: 1) Where is the best place to send the patches (I don't think I have commit access to that file directly, and even if I do, I imagine changes to core functionality need to be audited.)

Can you open an issue in our bug tracker and post a link to the patch? Also discussions should stand in the pear.core list. Thanks, that's what I needed to know. I'll prepare a patch and post it to pear-core.

Thanks

Well, this class is definitely not compatible with PHP4, but if PHP5.1 is a fine minimum version, that may make the class a little cleaner (e.g. better instanceof).

It is not yet a fine minimum version, but the more I think about pear and php5 the more I like to have pear and php5.1 :) --Pierre