Re: savepoint API
| From: | Lukas Smith | Date: | Tue, 18 Jul 2006 15:03:54 +0000 |
| Subject: | Re: savepoint API | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-43516@lists.php.net to get a copy of this message | ||
Kouber Saparev wrote:
I think it's ok like that, since you can only move "backwards" to savepoints, i.e. rollbacking. Once you rollback to a savepoint, you cannot access a savepoint which was defined after the current savepoint - which is of course normal, every statement after the savepoint should be "rolled back". So, providing an optional string parameter to rollback(), just like you've implemented it, sounds reasonable to me.Actually I gotten some feedback from people offlist as well and so I decided to remove setSavepoint() and releaseSavepoint() and moved the code into beginTransaction() and commit(). regards, Lukas