[PEPr] Comment on File Formats::File_MARC

Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for File Formats::File_MARC. Comment: If this is a PHP5 package, I don't see why you're using a) global constants b) a singleton object in global namespace. Singletons are to prevent that. c) The error stack shouldn't be global, an also should be instance-wise. What if I have 2 marc objects that give errors? d) function &getSubfields - Am I wrong or are objects always passed by ref in PHP5? So the ampersand isn't necessary. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=443 -- Sent by PEPr, the automatic proposal system at http://pear.php.net