[PEPr] Comment on Text::Text_CAPTCHA_Driver_Numeral
| From: | David Coallier | Date: | Mon, 16 Oct 2006 22:18:29 +0000 |
| Subject: | [PEPr] Comment on Text::Text_CAPTCHA_Driver_Numeral | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-44581@lists.php.net to get a copy of this message | ||
David Coallier (http://pear.php.net/user/davidc) has commented on the proposal for
Text::Text_CAPTCHA_Driver_Numeral.
Comment:
I have made it use
setFirstNumber()
setSecondNumber()
changed the set to generateFirstNumber() which calls setFirstNumber
passing generateNumber()
same goes for generateSecondNumber() -> setSecondNumber(generateNumber())
Although, the while is impossible in that case, I have to re-call the
generateOperation if I change the firstNumber in any matter. I have made
calculations generating + and - using array_rand, I have tested to see if
it would ever create a seg fault and I haven't seen it yet.
Let me know if you find it more clean now.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=451
--
Sent by PEPr, the automatic proposal system at http://pear.php.net